[Webkit-unassigned] [Bug 95536] Make compile with both OS(WINCE) and PLATFORM(QT) support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 4 09:02:38 PDT 2012


Patrick R. Gansterer <paroga at paroga.com> changed:

           What    |Removed                     |Added
 Attachment #162038|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #6 from Patrick R. Gansterer <paroga at paroga.com>  2012-09-04 09:02:50 PST ---
(From update of attachment 162038)
View in context: https://bugs.webkit.org/attachment.cgi?id=162038&action=review

> Source/WTF/wtf/unicode/icu/CollatorICU.cpp:45
> +#define strdup _strdup

please include <wtf/StringExtras.h> instead (outside of OS(WINCE)). It implements this logic already.

> Source/WebCore/platform/win/ClipboardUtilitiesWin.cpp:36
> +#if !OS(WINCE)
>  #include <shlwapi.h>
> +#endif

please move conditional includes after the regular ones

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list