[Webkit-unassigned] [Bug 95747] [BlackBerry] Browser is not sending secured Cookie back to server over HTTPS connection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95747


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #162040|review?                     |review-
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-09-04 07:41:34 PST ---
(From update of attachment 162040)
View in context: https://bugs.webkit.org/attachment.cgi?id=162040&action=review

Looks good, some stuff to fix still.

> Source/WebCore/ChangeLog:2
> +

One empty line too many.

> Source/WebCore/ChangeLog:11
> +        The problem was if the browser has never saved a secure protocol,

Can you rephrase this? It seems a bit terse.

> Source/WebCore/ChangeLog:18
> +        funciton.

Typo: function.

> Source/WebCore/platform/blackberry/CookieManager.cpp:212
> +    // Set the map to the non-secure version, so it'll search the mapping for a secure cookie

Lacks period.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.