[Webkit-unassigned] [Bug 95486] PAGE_POPUP: Using window.pagePopupController will crash in non-V8 build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95486





--- Comment #7 from Yong Li <yoli at rim.com>  2012-09-04 07:38:18 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > I guess the crash happens with normal web pages because DOMWindow objects for normal web pages don't have DOMWindowPagePopup supplement objects.
> > > 
> > > Anyway, the right fix is to add support of EnabledPerContext to JSC binding.
> > 
> > Exactly. But before EnabledPerContext being supported, can we make it a V8 binding only property?
> 
> Why do you need to make it V8-only?

Because it crashes on a non-V8 build.

> If you need no window.pagePopupController, you should exclude DOMWindowPagePopup.idl from build target.

DOMWindowPagePopup.idl is included in WebCore/CMakeLists.txt, which is a cross-platform file. I don't prefer to add platform-specific code to that cmake file. Any other solution?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.