[Webkit-unassigned] [Bug 95690] webkit_unit_tests-debug.apk does not include chromium_net.jar.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95690





--- Comment #1 from Peter Beverloo <peter at chromium.org>  2012-09-04 02:32:02 PST ---
Yes, we should explicitly include chromium_net.jar in the input_jars_paths list if we depend on it. Other WebKit binaries, such as DumpRenderTree and (less likely) TestWebKitAPI, may need to be updated too.

Our dependencies are a complete mess, and we need to be much more explicit about this. The right way to fix this would be:

1) net should depend on net_java (just like base should depend on base_java for target builds, etc).
2) libraries should explicitly depend on the jar files they need.

As such, adding the jar to input_jars_paths is fine. While you're at it, could you please change uses of the input_jars_paths list (on lines 175 and 185) to be a late expansion (i.e. change "<" to ">")? That brings us in line with Chromium's apk_test.gypi again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.