[Webkit-unassigned] [Bug 95549] [GTK] Add API to get/set the security policy of a given URI scheme

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95549


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #161654|review?                     |review-
               Flag|                            |




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2012-09-03 18:04:14 PST ---
(From update of attachment 161654)
View in context: https://bugs.webkit.org/attachment.cgi?id=161654&action=review

Looks good to me! Just a couple comments.

> Source/WebKit/gtk/webkit/webkitglobals.h:149
> + * @WEBKIT_SECURITY_POLICY_NO_ACCESS: Pages loaded with this URI scheme

WEBKIT_SECURITY_POLICY_NO_ACCESS seems a bit too broad. Perhaps WEBKIT_SECURITY_POLICY_NO_ACCESS_TO_OTHER_SCHEMES or something better?

> Source/WebKit/gtk/webkit/webkitglobals.h:155
> + * @WEBKIT_SECURITY_POLICY_CORS_ENABLED: URI scheme that can be sent CORS requests.

Agree with Mario here that you might want to link to the CORS spec.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.