[Webkit-unassigned] [Bug 95636] [EFL][WK2] Fix e_dbus_shutdown() error when exiting the Minibrowser

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 3 06:52:02 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=95636





--- Comment #10 from Jinwoo Song <jinwoo7.song at samsung.com>  2012-09-03 06:52:13 PST ---
(In reply to comment #7)
> (In reply to comment #4)
> > Actually, the fix seems consistent with the WebKit1 implementation so OK.
> > 
> > In addition to your fix, I would also add a check in BatteryProviderEfl::stopUpdating() / BatteryProviderEfl::startUpdating() to avoid such issue in the future. It should not cause any problem to call BatteryProviderEfl::stopUpdating() twice or BatteryProviderEfl::startUpdating() twice.
> 
> I agree with this.
> IMO, We need to add a flag to check for starting update.

I did not add a new flag to check the updating status but used the existing one, 
m_timer in the BatteryProviderEfl.h. By checking if the m_timer is active or not,
stopUpdating() is executed only when we are updating. 

Also, I added stopUpdating() in the destructor of BatteryClientEfl.cpp as we can 
check if we are updating or not.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list