[Webkit-unassigned] [Bug 95640] [EFL] Add missing semicolon at the end of some lines.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Sep 1 17:44:26 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=95640
--- Comment #6 from Byungwoo Lee <bw80.lee at samsung.com> 2012-09-01 17:44:35 PST ---
(In reply to comment #5)
> EWK_VIEW_TYPE_CHECK does not seem to have had any meaningful change, I don't understand the reason for the additional spaces at the end of the lines.
It was because that all the position of the '\' were fitted in the previous code.
>
> >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:168
> >> + } while (0)
> >
> > We don't technically need to do { } while(0) here. Why not simply get rid of the semicolon at the end of evas_object_smart_data_get(ewkView)?
>
> The best reason I can think of is convention.
Yes, I just add the while (0), but I think removing semicolon will be easier for the line. And with this additional fitting for '\' also not required.
I'll change those. Thanks :)
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list