[Webkit-unassigned] [Bug 91052] JSC: LLInt should auto-generate our cross-platform C++ interpreter

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 1 10:20:47 PDT 2012


--- Comment #28 from Filip Pizlo <fpizlo at apple.com>  2012-09-01 10:20:55 PST ---
(In reply to comment #26)
> The few style violations were intentional.  They were:
> 1. llint_unused uses underscore.  This was intentional to keep it consistent with how opcodes are named.
> 2. Use of more than 1 space between certain words in a comment block.  This was because I was expressing a column aligned table of info which necessitates the use of space for alignment.
> 3. No space around &&.  The style checker thought it's a logical AND operator, but it's actually a "get the address of a label" operator, and it does not make sense to have spaces around it where it is used.

Yeah, for changes in parts of the JIT and LLInt we end up getting loads of these sorts of warnings and we pretty much always ignore them.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list