[Webkit-unassigned] [Bug 91187] [EFL] Add dummy implementation of File system API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91187





--- Comment #15 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-09-28 22:23:24 PST ---
(From update of attachment 166172)
View in context: https://bugs.webkit.org/attachment.cgi?id=166172&action=review

>>> Source/WebCore/Modules/filesystem/LocalFileSystem.cpp:80
>>> +#if !PLATFORM(EFL)
>> 
>> Why do you disable this functions on EFL port ?
> 
> As you can see at https://bugs.webkit.org/show_bug.cgi?id=79193, 
> I'm planning to re-implement those functions in AsyncFileSystemEfl.cpp.
> 
> To make the path of the file system, FileSystemType is needed.
> But, FileSystemType is not a parameter of AsyncFileSystem::openFileSystem.
> So, I need to re-implement LocalFileSystem::requestFileSystem function to make
> proper file system path before calling AsyncFileSystem::openFileSystem.
> 
> Same as LocalFileSystem::readFileSystem.

IMO, it would be good if you re-implement functions you need in LocalFileSystemEfl.cpp.

> Source/WebCore/platform/efl/AsyncFileSystemEfl.cpp:57
> +void LocalFileSystem::deleteFileSystem(ScriptExecutionContext*, FileSystemType, PassOwnPtr<AsyncFileSystemCallbacks>)

Why do you implement LocalFileSystem member functions in AsyncFileSystem ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.