[Webkit-unassigned] [Bug 96637] Remove V8DOMWindowShell::getEntered

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96637





--- Comment #28 from Adam Barth <abarth at webkit.org>  2012-09-28 13:31:17 PST ---
(From update of attachment 166267)
View in context: https://bugs.webkit.org/attachment.cgi?id=166267&action=review

> Source/WebCore/bindings/v8/V8Binding.cpp:314
> +    V8DOMWindowShell::IsolatedContextData* isolatedShellData;

Would you be willing to initialize this scalar to 0? It always makes me worry to see uninitialized pointers.

> Source/WebCore/bindings/v8/V8DOMWindowShell.h:63
> +        static PassOwnPtr<IsolatedContextData> create(PassRefPtr<DOMWrapperWorld> world, PassOwnPtr<V8PerContextData> perContextData,
> +            PassRefPtr<SecurityOrigin> securityOrigin)

You can merge these lines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.