[Webkit-unassigned] [Bug 97879] New: Web Inspector: make HashSet memory instrumentation non-intrusive

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97879

           Summary: Web Inspector: make HashSet memory instrumentation
                    non-intrusive
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: yurys at chromium.org
                CC: timothy at apple.com, rik at webkit.org, keishi at webkit.org,
                    pmuellr at yahoo.com, joepeck at webkit.org,
                    pfeldman at chromium.org, yurys at chromium.org,
                    bweinstein at apple.com, apavlov at chromium.org,
                    loislo at chromium.org


Declaring reportMemoryUsage as a friend of HashSet and HashTable is considered harmful, so we should switch to using only public API of the classes. This way we will still be able to collect necessary information. The problem is that it will be easier to change the implementation and forget to update the instrumentation(which is probably fine since these classes don't change often), also we won't be able to automatically mark corresponding objects in the memory as instrumented while checking correctness of the memory instrumentation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.