[Webkit-unassigned] [Bug 91844] [WK2][GTK][EFL] Share WebKit2-GTK plugin process implementation with EFL port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 28 01:40:14 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=91844





--- Comment #57 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-09-28 01:40:39 PST ---
(In reply to comment #56)
> The latest patch (with sharable code) has got r+. IMHO we should make a final decision in which form the patch will be landed.
> 
> Carlos, would you like to have the separate files/implementation for:
>  - PluginProcessUnix.cpp
>  - PluginControllerProxyUnix.cpp
> for the port specific files qt/gtk/efl etc? In this case all of them will look mostly the same and have unimplemented all methods.
> 
> In my opinion this patch makes sense. If some has knowledge how those unimplemented methods should look like or knows whether they are depend on the port specific API/features/files now would be a good time to speak up!

We can just share the "code" of those not implemented files, and in case a port needs to add code in the future that is not specific to unix or that would require too many #ifdefs we can split the files again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list