[Webkit-unassigned] [Bug 96627] [EFL] Use the shareable GraphicsContext3DOpenGL* implementation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96627





--- Comment #10 from Regina Chung <heejin.r.chung at samsung.com>  2012-09-28 00:52:51 PST ---
(In reply to comment #8)
> (From update of attachment 164343 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164343&action=review
> > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:48
> > +        // WebKit1 code path.
> I don't understand this comment well.

I temporarily removed the WebKit1 related code because it brang up problems in WebKit2 but am planning on putting it back in with some fixes in another patch.
(https://bugs.webkit.org/show_bug.cgi?id=97651)
Anyways I changed the comment to make it a bit more understandable.

> > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:57
> > +        return;
> new line?

Added new line.

> > Source/WebCore/platform/graphics/efl/GraphicsContext3DPrivate.cpp:58
> > +    evas = ecore_evas_get(ecoreEvas);
> Why not define this here ?
> Evas* evas =  ecore_evas_get(ecoreEvas);

This also had to do with putting back the WebKit1 code in, but I changed the code as you suggested. I guess I shouldn't commit code that 'must' be fixed in the future :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.