[Webkit-unassigned] [Bug 89742] [Win] key event's location does not work on Windows platform.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89742


Takashi Sakamoto <tasak at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #162416|                            |review?
               Flag|                            |




--- Comment #19 from Takashi Sakamoto <tasak at google.com>  2012-09-28 00:48:55 PST ---
(From update of attachment 162416)
View in context: https://bugs.webkit.org/attachment.cgi?id=162416&action=review

Thank you for reviewing.

>> Source/WebCore/ChangeLog:9
>> +        directly provide a virtual keycode which distinguish between left-hand
> 
> These two lines of changelogs are messed up.

Done.

>> Source/WebCore/platform/win/KeyEventWin.cpp:196
>> +    // the right-hand ALT and CTRL keys.
> 
> This is quite obvious from the code.

Done.

>> Source/WebCore/platform/win/KeyEventWin.cpp:197
>> +    // However, if we don't need to support WindowsXP or older Windows,
> 
> Nit: Windows XP.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.