[Webkit-unassigned] [Bug 93473] Web Inspector: The front-end should provide the position in original source file when set a breakpoint

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93473





--- Comment #15 from Peter Wang <peter.wang at torchmobile.com.cn>  2012-09-27 23:38:05 PST ---
(In reply to comment #14)
> (From update of attachment 161964 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161964&action=review
> 
> Can you provide a test for this?
Most of the cases in path LayoutTests/inspector/debugger are the cases of JS with indent, since the JS code of them are formatted. 
And LayoutTests/inspector/debugger/script-formatter-breakpoints.html can be used to verify the case of unformatted JS code.
Actually, I've done DRT test for my patch using Qt build. 

> > Source/WebCore/bindings/js/ScriptDebugServer.cpp:144
> > +        m_lastExecutedLine = lineNumber;
> 
> has* methods should not modify the object, this is why in particular it was marked const.
ok, I'll put it in another place.

> > Source/WebCore/bindings/js/ScriptDebugServer.cpp:162
> > +        // Since frontend truncates the indent, so the first statement in a line must matches the breakpoint (line, 0).
> 
> typo: Since frontend truncates the indent, the first statement in a line must match the breakpoint
sorry, thx.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.