[Webkit-unassigned] [Bug 97697] [Qt][WRT] Unresolved external symbol errors with MSVC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97697





--- Comment #6 from Simon Hausmann <hausmann at webkit.org>  2012-09-27 03:11:05 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > I have successfully reproduced the build issue on Windows7 machine. A moved the WebKit directory to a longer path ("C:\WebKitBuildSlave\proba5beta\WebKit") that exactly the same as on the Win2008r2 machine.
> > 
> > At the same time we figured out with KBalazs that qt/TestRunnerQt.cpp exists in two location:
> > - $${ROOT_WEBKIT_DIR}/Tools/WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp
> > - $${ROOT_WEBKIT_DIR}/Tools/DumpRenderTree/qt/TestRunnerQt.cpp
> > and it seems the build system chose the wrong one. So I added the explicit path to Target.pri. I am looking forward to see the result of this build.
> 
> Argh ... MSVC always has problem with same filenames with batch build :-/
> In this case we usually renames files.

Aw snap, you're right.

Hmm, instead of renaming we could also perhaps handle QtInitializeTestFonts.cpp differently. For example we could simply have a QtInitializeTestFonts.cpp in InjectedBundle/qt that itself contains an #include "../../path/to/QtInitializeTestFonts.cpp" and thus avoid the include path addition

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.