[Webkit-unassigned] [Bug 17427] Line breaking opportunities at the end of a text node are missed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=17427





--- Comment #25 from Michael Saboff <msaboff at apple.com>  2012-09-26 09:48:21 PST ---
(In reply to comment #24)
> Michael, thanks for the explanation. I think I understand how your patch works. So my next question is, how would we make the the line-breaking functions take a UText if available and a String if not? Would it require changes to all platforms?
> 
> Also, given that UText is not available on all platforms, and what we want to do with it requires ICU 4 or later, would you be okay with using the StringBuilder-based implementation to fix the rendering bugs now and adding optimizations for ICU platforms afterwards in a separate patch?

I think all the platforms that use ICU are at ICU 4 or greater.  We just updated Mac to ICU 4.6.  I think Chromium is already at 4.6 or higher.  My proposed patch that used UText built on all platforms, although those changes are in Source/WebCore/platform/text/TextBreakIteratorICU.cpp.  I would suggest that you make your changes in an existing or new "ICU" file.

No sense to land a StringBuilder fix when we can make things better for ICU capable platforms.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.