[Webkit-unassigned] [Bug 84624] Table: padding on inline-element not calculated in cell-width

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84624





--- Comment #6 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-09-26 04:56:28 PST ---
(In reply to comment #3)
> (From update of attachment 154859 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154859&action=review
>
Thanks Julien for reviewing the patch. Have made changes as per your comments.
I agree, it would be safer to update |isPrevChildInlineFlow| at the end of the while loop. Have modified the changelog as well.

Shall ping Leviw for further reviews.

> > Julien, what do you think?
> 
> This patch will impact any RenderBlocks and not just RenderTableCells. The ChangeLog seems to suggest that this is table cell specific so it should be clarified.
> 
> > Source/WebCore/rendering/RenderBlock.cpp:5872
> > +                isPrevChildInlineFlow = false;
> 
> Interestingly, we don't set isPrevChildInlineFlow in the else branch below which looks suspicious. Ideally you want to update |isPrevChildInlineFlow| for every iteration so it should probably be pushed to the end of the while loop (outside of any branch to garantee that it is updated)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.