[Webkit-unassigned] [Bug 97647] New: A buggy python patch can kill all EWS bots

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97647

           Summary: A buggy python patch can kill all EWS bots
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Critical
          Priority: P1
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ossy at webkit.org
                CC: eric at webkit.org, tony at chromium.org, abarth at webkit.org,
                    dpranke at chromium.org


https://bugs.webkit.org/attachment.cgi?id=165713 in https://bugs.webkit.org/show_bug.cgi?id=97623
killed all EWS bots, they stucked in an infinite loop with the following error:

Traceback (most recent call last):
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/tool/main.py", line 55, in __init__
    MultiCommandTool.__init__(self)
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 221, in __init__
    self.commands = commands or [cls() for cls in self._find_all_commands() if cls.name]
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 185, in __init__
    AbstractRebaseliningCommand.__init__(self, options=port_options(platform='port/platform to use. Use glob-style wildcards for multiple ports'))
NameError: global name 'port_options' is not defined


We need a proper way to avoid this kind of problems in the future.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.