[Webkit-unassigned] [Bug 97624] New: [EFL][WK2] Some expected and actual parameters in unit tests are reversed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 25 19:52:22 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=97624
Summary: [EFL][WK2] Some expected and actual parameters in unit
tests are reversed
Product: WebKit
Version: 528+ (Nightly build)
Platform: Other
OS/Version: Linux
Status: NEW
Severity: Normal
Priority: P2
Component: WebKit EFL
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: jinwoo7.song at samsung.com
CC: demarchi at webkit.org
According to the gtest guide, EXPECT_XXX(expected, actual) is recommended but some unit tests do not follow this.
http://code.google.com/p/googletest/wiki/Primer
"In the event of a failure, Google Test prints both val1 and val2 . In ASSERT_EQ* and EXPECT_EQ* (and all other equality assertions we'll introduce later), you should put the expression you want to test in the position of actual, and put its expected value in expected, as Google Test's failure messages are optimized for this convention."
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list