[Webkit-unassigned] [Bug 90017] [Meta] [Shadow] contenteditable attribute for distributed nodes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90017





--- Comment #6 from Takashi Sakamoto <tasak at google.com>  2012-09-25 02:13:42 PST ---
(From update of attachment 161609)
View in context: https://bugs.webkit.org/attachment.cgi?id=161609&action=review

Thank you for reviewing.

>> Source/WebCore/css/StyleResolver.cpp:1783
>> +    if (m_distributedToInsertionPoint) {
> 
> This seems like an odd place for this code. Should this not be in StyleResolver::applyProperty?

In StyleResolver::applyProperty, I found that "case CSSPropertyWebkitUserModify:" is "ASSERT_NOT_REACHED();"
So did you mean StyleBuilder.cpp? i.e. adding a new class, e.g. ApplyPropertyUserModify and implementing an original applyInheritValue?

>> Source/WebCore/css/StyleResolver.cpp:1786
>> +        m_style->setUserModify(element->parentElement()->renderStyle()->userModify());
> 
> This looks fishy to me. So distributed nodes don't inherit any style but -webkit-user-modify?

Distributed nodes inherit styles except -webkit-user-modify from their rendering and style parents, because m_style->inheritFrom(m_parentStyle) has been already executed.
The code is for overriding -webkit-user-modify values by using shadow hosts' values.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.