[Webkit-unassigned] [Bug 95268] garden-o-matic doesn't handle multiple TestExpectations files properly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95268





--- Comment #7 from Ojan Vafai <ojan at chromium.org>  2012-09-24 10:48:21 PST ---
(In reply to comment #6)
> Just a random thought: if we _disable_ multi-platform expectations syntax in lieu of cascading expectations, we might be able to make the algorithm of collapsing a set of TestConfigurations into specifiers/modifiers easier, because now we have a simple tree structure to rely upon. Of course, this means more pain for gardeners (who now need to modify multiple files), but maybe that's not a big issue, if we have the right tooling?

I've thought a lot about this and see pros/cons in both directions. I think as long as we have a platform/chromium/TestExpectations file, it shouldn't be too much more work for gardeners. One advantage here is that there will be fewer duplicate line warnings because duplicates across files are allowed. The corollary, is that people are more likely to accidentally leave junk behind in some files.

That all said, I think we should do it for the following reasons:
-Makes Chromium less of a special-case port.
-We don't need to figure out which modifiers apply to which ports and in what way. The only platform modifiers would be Release and Debug. Nothing else.
-Simplifies the tooling code considerably.

The big downside here is that it's a good deal of tooling work. Not sure there's anyone with time to do it at the moment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.