[Webkit-unassigned] [Bug 76246] Incorrect rendering of borders on <col> with span > 1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 24 05:25:26 PDT 2012


--- Comment #11 from Arpita Bahuguna <arpitabahuguna at gmail.com>  2012-09-24 05:25:53 PST ---
(In reply to comment #6)
> (From update of attachment 161966 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161966&action=review

Hi Julien, thank-you for the review. Have made amends to handle most of the review comments except for the following two:

> > Source/WebCore/rendering/RenderTableCell.cpp:475
> > +                result = chooseBorder(CollapsedBorderValue(colElt->style()->borderEnd(), includeColor ? colElt->style()->visitedDependentColor(endColorProperty) : Color(), BCOL), result);
> result should be first as we return the first parameter in case of equivalent borders. The code is not really consistent here unfortunately and we should try to avoid adding more latent bugs. It should be easily testable using equivalent borders of different color.

'result' should be the second param here as when considering the preceeding column's end border, as per the specification, the left most should be given higher priority.
Also, have added a new test (last table in the added testcase) which highlights this issue. If result were to be given higher priority, the borders for the last table come as red, light brown, green and black instead of transparent/invisible, light green, dark green and black.

> > LayoutTests/ChangeLog:15
> > +        * fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Added.
> > +        * fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.txt: Added.
> > +        * fast/table/border-collapsing/collapsed-border-with-col-colgroup-span.html: Added.
> Could it be possible to change this into a ref-test?
I tried, but found it difficult to achieve the same results w/o using collapsed borders.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list