[Webkit-unassigned] [Bug 95341] Web Inspector: The JS code injected by worker inspector shouldn't be evaluated through JSMainThreadExecState

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 24 03:22:50 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=95341





--- Comment #4 from Peter Wang <peter.wang at torchmobile.com.cn>  2012-09-24 03:23:18 PST ---
(In reply to comment #3)
> (From update of attachment 161213 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=161213&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        No new test case.
> 
> Can this be tested?

Taking QT debug build as example, without my patch, when we click the link on the worker side-panel(refer to the attached picture), the Browser hits the assert statement. 

> > Source/WebCore/bindings/js/ScriptFunctionCall.cpp:40
> > +#ifndef NDEBUG
> 
> Do we have debug-related behavior here?
It's weird, it's not my code. It'll cleaned in the new patch.

> > Source/WebCore/inspector/InjectedScriptManager.h:71
> > +    explicit InjectedScriptManager(InspectedStateAccessCheck, bool = false);
> 
> bool isForWorker = false
ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list