[Webkit-unassigned] [Bug 97202] [GTK] Implement ViewState methods in PageClientImpl in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97202





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2012-09-20 14:54:56 PST ---
(From update of attachment 164898)
View in context: https://bugs.webkit.org/attachment.cgi?id=164898&action=review

This looks good to me, though changes to the test harness suggest that this will allow us to unskip tests or change results somehow.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:100
> +    gulong toplevelResizeGripVisibilityID;
> +    gulong toplevelFocusInEventID;
> +    gulong toplevelFocusOutEventID;

Maybe just unsigned long here?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:120
> +static void webkitWebViewBaseNotifyResizerSizeForWindow(WebKitWebViewBase* webViewBase)

I guess you can remove the "ForWindow" from the name since you are no longer passing it.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:254
> +    if (widgetIsOnscreenToplevelWindow(toplevel))
> +        webkitWebViewBaseSetToplevelOnScreenWindow(webView, GTK_WINDOW(toplevel));

Are there situations where a window can be realized already inside a toplevel window, without set_parent being called?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:743
> +    if (widgetIsOnscreenToplevelWindow(toplevel))
> +        webkitWebViewBaseSetToplevelOnScreenWindow(webViewBase, GTK_WINDOW(toplevel));
> +    else
> +        webkitWebViewBaseSetToplevelOnScreenWindow(webViewBase, 0);

If you like, this could just be:

webkitWebViewBaseSetToplevelOnScreenWindow(webViewBase, widgetIsOnscreenToplevelWindow(toplevel) ? GTK_WINDOW(toplevel) :  0);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.