[Webkit-unassigned] [Bug 97186] QuickTime movie is not scaled when opened by movie file URL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97186





--- Comment #2 from Eric Carlson <eric.carlson at apple.com>  2012-09-20 09:53:21 PST ---
(From update of attachment 164914)
View in context: https://bugs.webkit.org/attachment.cgi?id=164914&action=review

> Source/WebCore/ChangeLog:8
> +        This patch developed by Yandex LLC.

This is unusual for a ChangeLog entry. If you want attribution you can add a copyright line to the file you modified.

> Source/WebCore/html/PluginDocument.cpp:105
>          m_embedElement->setAttribute(typeAttr, loader->writer()->mimeType());
> +    const PluginData* pluginData = document()->page()->pluginData();
> +    String mimeType = loader->writer()->mimeType();
> +    String pluginName = pluginData ? pluginData->pluginNameForMimeType(mimeType) : String();
> +    if (pluginName.contains("QuickTime", false)) {
> +        // By default QuickTime plugin will not scale when browser window resizes.
> +        const QualifiedName scaleAttr(nullAtom, "scale", xhtmlNamespaceURI);
> +        m_embedElement->setAttribute(scaleAttr, "aspect");

This indentation is wrong.

You should define "mimeType" earlier in the function and use it in "m_embedElement->setAttribute(...)"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.