[Webkit-unassigned] [Bug 97045] webkit-patch rebaseline does the wrong thing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 19 11:19:57 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=97045





--- Comment #5 from Adam Barth <abarth at webkit.org>  2012-09-19 11:20:27 PST ---
I knew about this issue when I designed the algorithm, but it's not clear to me how to fix it.  The problem is that you often want to change the results for the other ports.

Consider the case where revision N changes the results of test X and previously all the Windows versions had the same results for test X.  For whatever reason, the WinXP bot hasn't processed revision N yet, so the bot still sees old result.  The right solution here is to guess that the result is going to stay the same across Windows versions and to overwrite the chromium-win results with the results from the Win7 bot.  If later we discover that WinXP has a different result, we can then recode that in the chromium-win-xp directory.

The algorithm is designed to be eventually correct.  If you keep rebaselining, you'll eventually get to the right state.  You just might not get there in one step.  t's impossible to always know what the correct final configuration is, so we have some basic heuristics in place.  It's very likely there are ways to improve the heuristics.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list