[Webkit-unassigned] [Bug 97032] Web Inspector: load sourcemaps asynchronously, part 1/2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97032





--- Comment #5 from johnjbarton <johnjbarton at chromium.org>  2012-09-19 09:56:41 PST ---
(In reply to comment #4)
> (From update of attachment 164624 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164624&action=review
> 
> > Source/WebCore/inspector/front-end/CompilerScriptMapping.js:96
> > +                script.setSourceMapping(this);
> 
> This means the script won't have source mapping until source map is loaded, which means stopping on breakpoint at this point would break things.

Specifically, Script.rawLocationToUILocation will fail when this._sourceMapping is undefined, correct?

(I believe this already occurs, at least I recall seeing exceptions related to rawLocationToUILocation).

Assuming we want async, then it's impossible to avoid a time when the mapping will be incorrect. So I guess we need to minimize the damage.

Based on DebuggerModel.js rawLocationToUILocation can sometimes return null; UISourceCode.js returns null from uiLocationToRawLocation() if !this._sourceMap. So one solution is to cause Script.rawLocationToUILocation to return null if this._sourceMapping is undefined.

BTW it looks like http/tests/inspector/compiler-source-mapping-debug.html will fail if we complete 2/2 for exactly the reason you cite. So in addition to the issue you raise, we need a way to test breakpoints with source mapping under async for 2/2.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.