[Webkit-unassigned] [Bug 65766] [GTK] OSAllocator::reserveUncommitted should not commit physical memory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=65766


Uli Schlachter <psychon at znc.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #164321|0                           |1
        is obsolete|                            |
 Attachment #164570|                            |review?, commit-queue?
               Flag|                            |




--- Comment #21 from Uli Schlachter <psychon at znc.in>  2012-09-18 09:03:39 PST ---
Created an attachment (id=164570)
 --> (https://bugs.webkit.org/attachment.cgi?id=164570&action=review)
New patch for using mmap(PROT_NONE) and mprotect() for reserving virtual memory.

(In reply to comment #20)
> (In reply to comment #19)
> > Re-opened since this is blocked by 96966
> 
> The patch is reverted by https://trac.webkit.org/changeset/128818 
> because it broke everything. (At least Qt, GTK, EFL) No, I won't 
> upload backtraces, links, etc. build.webkit.org is your friend,
> you guys should have watch it after landing this patch ...

Urgh. I'm sorry. I did two big mistakes. The bigger one was not to test the changes I did in response to the style warnings. The second mistake was changing "if (mprotect() != 0)" into "if (!mprotect())".

So here is a new patch which removes those evil "!". I even tested this one.

Again: Sorry, entirely my fault.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.