[Webkit-unassigned] [Bug 96974] [EFL][WK2] Add APIs to enable or disable developerExtraEnabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96974





--- Comment #2 from Christophe Dumez <christophe.dumez at intel.com>  2012-09-18 06:00:28 PST ---
(From update of attachment 164490)
View in context: https://bugs.webkit.org/attachment.cgi?id=164490&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL][WK2] Add APIs to enable or disable developerExtraEnabled

How about "Add setting to toggle developer extensions" ?

> Source/WebKit2/ChangeLog:8
> +        This is required to allow inspecting page.

"inspecting page" ? Web Inspector page?

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:113
> +/**

You're adding public API, please add unit tests for this.

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:118
> + *

We should indicate the default value for this setting.

> Source/WebKit2/UIProcess/API/efl/ewk_settings.h:130
> +EAPI Eina_Bool ewk_settings_enable_developer_extras_get(const Ewk_Settings *settings);

We should indicate the default value for this setting.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.