[Webkit-unassigned] [Bug 96944] New: check-webkit-style should warn when using booleans where enums are better

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 17 12:34:52 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96944

           Summary: check-webkit-style should warn when using booleans
                    where enums are better
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: abarth at webkit.org, levin at chromium.org,
                    rniwa at webkit.org


check-webkit-style should warn when using booleans where enums are better

Cases where bools are used in multi-argument functions are almost always wrong and should be enums instead.

foo(baz, true)

and

void bar(void* ptr, bool baz = true)

are just confusing and check-webkit-style should warn and instruct individuals to fix them with enums.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list