[Webkit-unassigned] [Bug 96790] [V8] Prevent workers from calling back into other worlds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96790





--- Comment #4 from Dan Carney <dcarney at google.com>  2012-09-14 13:26:51 PST ---
(In reply to comment #3)
> (From update of attachment 164161 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=164161&action=review
> 
> > Source/WebCore/bindings/v8/WorldContextHandle.cpp:51
> > +    if (v8::Context::InContext()) {
> > +        v8::Handle<v8::Context> context = v8::Context::GetCurrent();
> > +        if (!context.IsEmpty()) {
> 
> This is somewhat redundant.  You can skip the v8::Context::InContext() call and just test whether v8::Context::GetCurrent() returns an empty handle.

That's what I had at first, but v8 crashes on GetCurrent when not in context.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.