[Webkit-unassigned] [Bug 84796] Implement the new stacking layer needed by the Fullscreen API and the new <dialog> element

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 14 10:09:45 PDT 2012


--- Comment #4 from Jer Noble <jer.noble at apple.com>  2012-09-14 10:10:13 PST ---
Seems like a good approach to me.(In reply to comment #3)
> It seems that RenderFullScreen works now by wrapping a renderer when its element becomes full screen and then unwrapping when it's no longer full screen. So there is one element (and its subtree) that is full screen at a time.
> I wonder if we can do something like this instead:
> - RenderFullScreen (perhaps renamed "RenderTopLayer") is a child of RenderView
> - When an element is added to the top layer, its renderer becomes a child of RenderFullScreen
> - When an element is removed from the top layer, its renderer is returned to its original place
> - RenderFullScreen handles the special layout and stacking of the elements as described in the spec (z-index has no effect, position:"static" computes to "absolute", and the static position for top, left, right are zero).
> Does that sound like an okay approach? Maybe dynamic changes to the DOM tree would be problematic for returning no longer fullscreened elements to their original place in the render tree.

I would hope that returning un-fullscreened element to their original place would fall out of recalculating the render tree after a style change, in which case changes to the DOM tree during full screen wouldn't be problematic.

I like the idea of replacing RenderFullScreen with a RenderTopLayer-like object.  I'm pretty optimistic about this approach.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list