[Webkit-unassigned] [Bug 96471] [chromium] When running layout tests on android judge about installation success from adb command exit status

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96471





--- Comment #3 from Peter Beverloo <peter at chromium.org>  2012-09-14 05:49:42 PST ---
Hi Egor,

Thank you for the patch! I tried to see if we could rely on the exit codes, and got the result listed at the bottom of this message. It returned "0" regardless of whether the installation succeeded, so I'm afraid it may not be possible to rely on it being right.

A concern I have is that we need to execute the same command twice in order to get the command's output. This does not reproduce on the bots, and as far as I'm aware it neither reproduces for anyone locally: we've been using this code for quite a while now, and various people have ran layout tests.

Could you emphasize on the set up you have, and the output it produces for that environment? I'm interested in seeing whether we can find a better solution, but would like to understand the situation for that.

---

beverloo /buildbot/WebKit  $ adb install -r out/Release/TestWebKitAPI_apk/TestWebKitAPI-debug.apk 
echo6005 KB/s (10398532 bytes in 1.691s)
    pkg: /data/local/tmp/TestWebKitAPI-debug.apk
Success
beverloo /buildbot/WebKit  $ echo $?
0
beverloo /buildbot/WebKit  $ adb install out/Release/TestWebKitAPI_apk/TestWebKitAPI-debug.apk 
5597 KB/s (10398532 bytes in 1.814s)
    pkg: /data/local/tmp/TestWebKitAPI-debug.apk
Failure [INSTALL_FAILED_ALREADY_EXISTS]
beverloo /buildbot/WebKit  $ echo $?
0

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.