[Webkit-unassigned] [Bug 96481] [Qt][WK2] Add API to find text from page

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96481





--- Comment #9 from Andras Becsi <abecsi at webkit.org>  2012-09-14 04:38:08 PST ---
(From update of attachment 164054)
View in context: https://bugs.webkit.org/attachment.cgi?id=164054&action=review

I think the API looks OK now. Simon, what do you think?
Also Tor Arne might have comments on the MiniBrowser QML part.

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1343
> +    d->webPageProxy->findString(string, wkOptions, std::numeric_limits<unsigned>::max()-1);

Missing space around the "-" after max().

> Source/WebKit2/UIProcess/qt/QtWebPageFindClient.h:24
> +#include <QtGlobal>

This include seems to be unneeded in the header.

> Source/WebKit2/UIProcess/qt/QtWebPageFindClient.h:26
> +#include <WebFrameProxy.h>

Ditto.

> Tools/MiniBrowser/qt/qml/BrowserWindow.qml:356
> +    Rectangle {
> +        id: findBar

I think the findBar might be covered by the page when scrolling to the next occurence so you probably need to adjust z as we do for the navigationBar.

> Tools/MiniBrowser/qt/qml/BrowserWindow.qml:424
> +                    font {
> +                        pointSize: 11
> +                        family: "Sans"
> +                        }

The indentation is off for the bracket.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.