[Webkit-unassigned] [Bug 93597] Add DeviceController to support DOMWindow device events

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 13 19:55:46 PDT 2012


--- Comment #59 from Kihong Kwon <kihong.kwon at samsung.com>  2012-09-13 19:56:12 PST ---
(From update of attachment 162456)
View in context: https://bugs.webkit.org/attachment.cgi?id=162456&action=review

>> Source/WebCore/page/DOMWindowDeviceProvider.h:31
>> +class DOMWindowDeviceProvider : public Supplement<DOMWindow> {
> I don't understand the point of DOMWindowDeviceProvider.  In a previous iteration of this patch, you were storing a bunch of per-DOMWindow state.  I asked you to create a Supplement<DOMWindow> to store that state, but this class doesn't actually store any state.

If I make Supplement<DOMWindow>, I need to make unnecessary object for attaching DOMWindow.
But I think in this case it is enough to keep window pointer in the DeviceController.
Therefore I will remove this class.

>> Source/WebCore/page/DeviceClient.h:34
>> +    virtual PassRefPtr<Event> lastEvent() const = 0;
> Does this function transfer ownership of the last event?  I would have expected this to just be an getter.  If so, it should return a raw Event*

Yes, we need to transfer ownership to EventTarget When client create a event to fire.
But, I think this function is not good to check weather there is a preserved event or not in the client, therefore I will add hasPreservedEvent() for checking.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list