[Webkit-unassigned] [Bug 96683] Add min and max input field values to Chromium API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96683


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #163982|review?                     |review-
               Flag|                            |




--- Comment #8 from Kent Tamura <tkent at chromium.org>  2012-09-13 17:48:55 PST ---
(From update of attachment 163982)
View in context: https://bugs.webkit.org/attachment.cgi?id=163982&action=review

> Source/WebKit/chromium/ChangeLog:8
> +        Required to correctly bound values in native widgets used, for example, for date entry in Chrome on Android.

I'm not sure this should be done in WebTextInputInfo.  Can we obtain them from WebInputElement? Can we expose WebCore/platform/DateTimeChooser.h via WebKit API?

> Source/WebKit/chromium/public/WebTextInputInfo.h:61
> +    double min;
> +
> +    // The maximum value of the field (only meaningful for numbers, ranges,
> +    // and date or time based fields).
> +    double max;
> +

min and max should be initialized in the constructor.
Also, we should have "step" value.

> Source/WebKit/chromium/tests/WebViewTest.cpp:377
> +    EXPECT_EQ((double)1000*24*60*60, info.max);
> +    EXPECT_EQ((double)-1000*24*60*60*2, info.min);

Do not use C-style cast.  In this case, 1000.0 * 24 * 60 * 60 works without the cast.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.