[Webkit-unassigned] [Bug 96683] Add min and max input field values to Chromium API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96683





--- Comment #5 from Darin Adler <darin at apple.com>  2012-09-13 14:20:07 PST ---
(From update of attachment 163964)
View in context: https://bugs.webkit.org/attachment.cgi?id=163964&action=review

> Source/WebKit/chromium/src/WebTextInputInfo.cpp:45
> +        && min == min
> +        && max == max;

Missing the "other." prefix on both of these lines.

> Source/WebKit/chromium/src/WebViewImpl.cpp:2162
> +        if (input->isNumberField()
> +            || input->isRangeControl()
> +            || input->isDateField()
> +            || input->isDateTimeField()
> +            || input->isDateTimeLocalField()
> +            || input->isMonthField()
> +            || input->isWeekField()
> +            || input->isTimeField()) {
> +            info.min = input->minimum();
> +            info.max = input->maximum();

This long if statement is bad for maintenance of HTMLInputElement. We may add new types or decide not to use this style of boolean getter. Is there some reason you can’t just call minimum and maximum unconditionally?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.