[Webkit-unassigned] [Bug 96499] [EFL] Remove some parameters in browserCreate()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96499





--- Comment #9 from Seokju Kwon <seokju.kwon at samsung.com>  2012-09-12 21:42:43 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > 
> > > How about adding 'settings' to a struct of ELauncher?
> > > 
> > > +typedef struct _ELauncher_Settings {
> > > +    const char *userAgent;
> > > +    const char *engine;
> > > +    const char *backingStore;
> > > +    unsigned char isFlattening;
> > > +    unsigned char isFullscreen;
> > > +    const char *databasePath;
> > > +} ELauncher_Settings;
> > > +
> > >  typedef struct _ELauncher {
> > >      Ecore_Evas *ee;
> > >      Evas *evas;
> > >      Evas_Object *bg;
> > >      Evas_Object *browser;
> > >      Url_Bar *url_bar;
> > > -    const char *theme;
> > > -    const char *userAgent;
> > > -    const char *backingStore;
> > > -    unsigned char isFlattening;
> > > +    ELauncher_Settings *settings;
> > >  } ELauncher;
> > 
> > Looks better to me. Ryuan, how do you think ?
> 
> Seokju, can I know how do you pass settings when F9 is pressed ?

evas_object_event_callback_add(app->browser, EVAS_CALLBACK_KEY_DOWN, on_key_down, app)

on_key_down(void *data, Evas *e, Evas_Object *obj, void *event_info)
The first parameter in this definition will have the same value passed to evas_object_event_callback_add(), if ELauncher has 'settings'.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.