[Webkit-unassigned] [Bug 96499] [EFL] Remove some parameters in browserCreate()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96499





--- Comment #7 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-09-12 20:49:59 PST ---
(In reply to comment #6)

> How about adding 'settings' to a struct of ELauncher?
> 
> +typedef struct _ELauncher_Settings {
> +    const char *userAgent;
> +    const char *engine;
> +    const char *backingStore;
> +    unsigned char isFlattening;
> +    unsigned char isFullscreen;
> +    const char *databasePath;
> +} ELauncher_Settings;
> +
>  typedef struct _ELauncher {
>      Ecore_Evas *ee;
>      Evas *evas;
>      Evas_Object *bg;
>      Evas_Object *browser;
>      Url_Bar *url_bar;
> -    const char *theme;
> -    const char *userAgent;
> -    const char *backingStore;
> -    unsigned char isFlattening;
> +    ELauncher_Settings *settings;
>  } ELauncher;

Looks better to me. Ryuan, how do you think ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.