[Webkit-unassigned] [Bug 90968] [NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW

Wed Sep 12 09:28:09 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=90968

Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #163643|review?                     |review-
               Flag|                            |

--- Comment #11 from Dirk Pranke <dpranke at chromium.org>  2012-09-12 09:28:34 PST ---
(From update of attachment 163643)
View in context: https://bugs.webkit.org/attachment.cgi?id=163643&action=review

> Tools/Scripts/webkitpy/layout_tests/port/driver.py:352
> +        command += "'" + self._port.get_option("time_out_ms")

Perhaps this should only be passed if we know that the driver supports this argument? What will other ports do if they see this?

Also, self._port.get_option('time_out_ms') will use the global timeout setting, not the per-test setting, meaning that you won't have two different values for normal tests and slow tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.