[Webkit-unassigned] [Bug 94925] [EFL][UT]Refactoring an implementation of testing framework for wk1.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=94925





--- Comment #6 from Krzysztof Czech <k.czech at samsung.com>  2012-09-12 03:12:47 PST ---
(From update of attachment 160433)
View in context: https://bugs.webkit.org/attachment.cgi?id=160433&action=review

> Source/WebKit/efl/ChangeLog:5
> +

Will correct

> Source/WebKit/efl/ChangeLog:11
> +

You're right

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp:79
> +

Providing extra parameters of detailed warnings like (-Wunused-parameter) to gcc/g++ the warning will occur, despite it's a cpp file.

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.cpp:85
>  {

I agree with you, runTest() might be a little ambiguous.
Having something like waitUntilLoadFinished will assure that page loading is completed.
Generally this method is addressed for testing like getters/setters, but yes
to void some potential problems your suggestion is good.

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.cpp:81
>  {

Ok, ewk_view_uri_set can be used directly.

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.cpp:91
>  

Will correct

>> Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.h:46
>>      EWKTestView(const EWKTestView&);
> 
> Please add explicit.

I think adding explicit to private copy constructor is not needed.

>> Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.h:-66
>> -    OwnPtr<Evas_Object> m_webView;
> 
> Can I know why you change OwnPtr<Evas_Object> to Evas_Object* ?

I wanna make sure m_webView and m_ecoreEvas are deleted before ecore_evas_shutdown.
Despite the fact test view is destructed before ecore_evas_shutdown having OwnPtr
I had some strange assertion from efl. That's way I don't use OwnPtr in this case.

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestView.h:50
>      int m_width, m_height;

to have compatibility with getopt_long

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.