[Webkit-unassigned] [Bug 93443] Web Inspector: Protocol Extension: Add "regionLayoutUpdate" event

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93443





--- Comment #39 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2012-09-12 03:02:24 PST ---
(From update of attachment 163559)
View in context: https://bugs.webkit.org/attachment.cgi?id=163559&action=review

The change looks good, but I have a CSSStyleModel API concern now that getNamedFlowCollectionAsync() is made use of.

> Source/WebCore/inspector/InspectorCSSAgent.cpp:274
> +        namedFlows.append(std::make_pair(it->first, it->second));

You need to double-check, but seemingly, namedFlows.append(*it); will have the same effect.

> Source/WebCore/inspector/front-end/CSSStyleModel.js:180
> +    getNamedFlowCollectionAsync: function(documentNodeId, userCallback)

The method is named getNamedFlowCollectionAsync, however its result is "namedFlowCollection.namedFlowMap". Looking at its sole usage (in the real code), I guess it would be more appropriate to return namedFlowCollection to the userCallback (e.g. you wouldn't have to "this._namedFlowCollections[documentNodeId].flowByName(flowName)" in getFlowByNameAsync but rather "namedFlowCollection.flowByName(flowName)") - otherwise the returned result is just used to check for errors and discarded afterwards.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.