[Webkit-unassigned] [Bug 96466] New: JSC: Refactor Opcodes to distinguish between core and extension opcodes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 11 21:52:04 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96466

           Summary: JSC: Refactor Opcodes to distinguish between core and
                    extension opcodes
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mark.lam at apple.com


Previously, in the llint C++ interpreter (in LowLevelInterpreter.h), I declared a handful of llint opcode aliases for opcode that look like this:

const OpcodeID llint_op_call = op_call;
const OpcodeID llint_op_call_eval = op_call_eval;
...

When r128219 landed, it added a reference to llint_op_get_array_length, and this broke the C++ llint.  This demonstrates that the above approach is too fragile in practice.  So, I will refactor the FOR_EACH_OPCODE_ID() macro to create a separate FOR_EACH_CORE_OPCODE_ID() macro.  This FOR_EACH_CORE_OPCODE_ID() macro will be used to automatically declare the llint opcode aliases that the C++ llint needs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list