[Webkit-unassigned] [Bug 90968] [NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90968





--- Comment #6 from Peter Gal <galpeter at inf.u-szeged.hu>  2012-09-11 07:52:08 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=163359&action=review

> Tools/DumpRenderTree/DumpRenderTreeCommon.cpp:76
> +            std::string k = tokenizer.next();
> +            result.timeout_ms = (atoi(k.c_str()));

What does the 'k' mean? Also there is an extra () around the atoi. Hmmm... maybe we should check if there is a next token at all, like in the -p case.

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:729
> +    DumpRenderTree::readTimeout(input);

Why is this required? In the readTimeout you'll parse the input again whit the parseInputLine method, like at the start of this method. Processing the 'command' could be performed here or not? (maybe I'm missing something?)

> Tools/Scripts/webkitpy/layout_tests/port/driver.py:342
> +        command += "'" + self._port._options.time_out_ms

Accessing members marked private (_options) isn't really a good idea. Maybe there is a getter for it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.