[Webkit-unassigned] [Bug 95690] webkit_unit_tests-debug.apk does not include chromium_net.jar.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=95690


Peter Beverloo <peter at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #163344|                            |commit-queue?
               Flag|                            |




--- Comment #7 from Peter Beverloo <peter at chromium.org>  2012-09-11 06:00:57 PST ---
(From update of attachment 163344)
View in context: https://bugs.webkit.org/attachment.cgi?id=163344&action=review

Looks good to me, thanks Philippe! Adam, mind doing the formal review?

> Source/WebKit/chromium/ChangeLog:1
> +2012-09-06  Philippe Liard  <pliard at google.com>

nit: You may want to update your git configuration to have your @chromium.org e-mail address.

> Source/WebKit/chromium/ChangeLog:3
> +        Depend on {base,net} GYP targets rather than {base,net}_java.

nit: For future reference: If your patch only touches Chromium code (moreso: files only used by Chromium), it's generally a good idea to include a [Chromium] prefix in your title.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.