[Webkit-unassigned] [Bug 96308] percentage widths rendered wrong in vertical writing mode with orthogonal parent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96308


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alecflett at chromium.org,
                   |                            |hyatt at apple.com,
                   |                            |jochen at chromium.org,
                   |                            |tony at chromium.org




--- Comment #1 from Ojan Vafai <ojan at chromium.org>  2012-09-10 18:59:11 PST ---
RenderBox::computePercentageLogicalHeight is just wrong. All the places where it calls things like cb->logicalHeight(), it needs to be calling something like logicalHeightForContainingBlock(cb). Really, this->logicalHeightForChild(cb) would do the right thing, but the containingBlock is not this's child. It seems a shame to add a new set of methods here when we have a set that does the right thing but is named wrong.

We could rename these logicalHeightFor(RenderBox* other)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.