[Webkit-unassigned] [Bug 89666] Separate WebKit2 instances use the same local storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89666





--- Comment #29 from Andras Becsi <abecsi at webkit.org>  2012-09-10 03:37:44 PST ---
(From update of attachment 163054)
View in context: https://bugs.webkit.org/attachment.cgi?id=163054&action=review

I think this patch is an improvement, though I still find the ChangeLog a bit too brief about the issue that is being fixed.

> Source/WebKit2/ChangeLog:8
> +        WebContext has been extended for the paralelly started WTRs to use

*parallelly*

> Source/WebKit2/ChangeLog:12
> +        separate directories for their local storage.
> +        platformDiskCacheDirectory API has been added to the existing
> +        platformLocalStorageDirectory and platformDataBaseDirectory APIs.
> +

I think it would be good to explain a bit more why this change is needed and what the symptoms of the bug are.

Probably also refer to https://bugs.webkit.org/show_bug.cgi?id=77730 and the special for Qt to run multiple run-webkit-test instances in parallel.

> Source/WebKit2/Shared/WebProcessCreationParameters.h:-104
>      // FIXME: These should be merged with CFURLCache counterparts below.
> -    String nsURLCachePath;
> -    SandboxExtension::Handle nsURLCachePathExtensionHandle;

Following the FIXME comment to me it looks like the cfURLCachePath below is used for the same purpose on Windows as nsURLCachePath on Mac.

Doesn't this patch also affect the need for cfURLCachePath on Windows?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.