[Webkit-unassigned] [Bug 96201] [EFL][WK2] WKEinaSharedString needs a function to adopt eina stringshare.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=96201





--- Comment #8 from Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com>  2012-09-10 00:24:26 PST ---
(From update of attachment 163001)
At first WKEinaSharedString class contains already WKEinaSharedString(WKAdoptTag, WKStringRef); so there is no need to inject friend functions 
and private constructors, you can follow existing pattern.
Secondly, WKAdoptTag is quite OK to use here IMHO, and it will look much more readable than just 'bool'.
Thirdly, adoption is needed for the strings which have been already shared, right? So why don't you point that out? We could use 
'Eina_Stringshare *' type for the argument.

Informal R-

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.