[Webkit-unassigned] [Bug 96201] [EFL][WK2] WKEinaSharedString needs a function to adopt eina stringshare.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 9 11:10:44 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=96201





--- Comment #2 from Simon Hausmann <hausmann at webkit.org>  2012-09-09 11:11:01 PST ---
(From update of attachment 163001)
View in context: https://bugs.webkit.org/attachment.cgi?id=163001&action=review

> Source/WebKit2/UIProcess/API/cpp/efl/WKEinaSharedString.h:73
> +WK_EXPORT WKEinaSharedString adoptEinaStringShare(const char* string);

Why not make it an overloaded constructor instead? WKEinaSharedString(AdoptTag, const char*) ? Seems more consistent with other adoption patterns in WebKit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list